Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
Date: 2019-06-28 10:15:56
Message-ID: CAPmGK155Xh9hPkK=2O9vy7kS9yHsSKTVdbnj7ieUhgQ370Ezxg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Julien,

On Fri, Jun 28, 2019 at 6:54 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Fri, Jun 28, 2019 at 11:39 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > In postgresAcquireSampleRowsFunc, we 1) determine the fetch size and
> > then 2) construct the fetch command in each iteration of fetching some
> > rows from the remote, but that would be totally redundant.
>
> Indeed.
>
> > Attached
> > is a patch for removing that redundancy.
>
> It all looks good to me! I marked it as ready for committer.

Cool! I'll commit the patch if there are no objections. Thanks for reviewing!

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2019-06-28 10:56:20 Re: Implementing Incremental View Maintenance
Previous Message Yugo Nagata 2019-06-28 10:01:43 Re: Implementing Incremental View Maintenance