Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
Date: 2019-06-28 09:54:34
Message-ID: CAOBaU_ZV6MTDDKm+4RJKKUA4WYsgPC9P4cLiB0vjwAsOB-xHcw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 28, 2019 at 11:39 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> In postgresAcquireSampleRowsFunc, we 1) determine the fetch size and
> then 2) construct the fetch command in each iteration of fetching some
> rows from the remote, but that would be totally redundant.

Indeed.

> Attached
> is a patch for removing that redundancy.

It all looks good to me! I marked it as ready for committer.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-06-28 09:56:15 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Peter Eisentraut 2019-06-28 09:51:01 Re: allow_system_table_mods stuff