| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc |
| Date: | 2019-07-03 09:01:36 |
| Message-ID: | CAPmGK17xAJKDQ9aqaF3PeR348-KEc7rXrBmoSgVwtyjpyi5akA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 28, 2019 at 7:15 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, Jun 28, 2019 at 6:54 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > On Fri, Jun 28, 2019 at 11:39 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > > In postgresAcquireSampleRowsFunc, we 1) determine the fetch size and
> > > then 2) construct the fetch command in each iteration of fetching some
> > > rows from the remote, but that would be totally redundant.
> >
> > Indeed.
> >
> > > Attached
> > > is a patch for removing that redundancy.
> >
> > It all looks good to me! I marked it as ready for committer.
>
> Cool! I'll commit the patch if there are no objections. Thanks for reviewing!
Pushed.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Shaplov | 2019-07-03 09:04:32 | Re: [PATCH][PROPOSAL] Add enum releation option type |
| Previous Message | Daniel Gustafsson | 2019-07-03 08:56:41 | Re: Replacing the EDH SKIP primes |