Re: macos exported symbols list not used for loadable modules

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macos exported symbols list not used for loadable modules
Date: 2025-06-05 17:28:01
Message-ID: CAOYmi+kPMkcWNaUOrjS=SMi+SUfR-pY_egXYX3LymBGu1gjq3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 3, 2025 at 12:48 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On macOS, when building with the make system, the exported symbols list
> (SHLIB_EXPORTS) is ignored. I don't think that is intentional. It was
> probably just forgotten, since that combination has never actually been
> used until now (for libpq-oauth).

Oops, thank you for noticing that.

> (Alternatively: Am I missing something? Is this combination not useful?
> Was it not supported in older versions at some point? I couldn't
> think of anything.)
>
> The meson build system handles this correctly.
>
> I suggest that we fix this. I attach patch 0001 with a minimal fix,
> patch 0002 is a bit more refactoring to make the code match the layout
> for other platforms.

LGTM, and works on my machine. Unfortunately I don't have any insight
into the history.

Thanks!
--Jacob

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-06-05 18:32:10 Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring
Previous Message Álvaro Herrera 2025-06-05 17:05:28 Re: ABI Compliance Checker GSoC Project