From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: macos exported symbols list not used for loadable modules |
Date: | 2025-06-10 05:15:38 |
Message-ID: | ce41b8c7-cbeb-456a-bd43-2a6d619c98dd@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 05.06.25 19:28, Jacob Champion wrote:
> On Tue, Jun 3, 2025 at 12:48 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> On macOS, when building with the make system, the exported symbols list
>> (SHLIB_EXPORTS) is ignored. I don't think that is intentional. It was
>> probably just forgotten, since that combination has never actually been
>> used until now (for libpq-oauth).
>
> Oops, thank you for noticing that.
>
>> (Alternatively: Am I missing something? Is this combination not useful?
>> Was it not supported in older versions at some point? I couldn't
>> think of anything.)
>>
>> The meson build system handles this correctly.
>>
>> I suggest that we fix this. I attach patch 0001 with a minimal fix,
>> patch 0002 is a bit more refactoring to make the code match the layout
>> for other platforms.
>
> LGTM, and works on my machine. Unfortunately I don't have any insight
> into the history.
Ok, fix committed.
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2025-06-10 05:34:32 | Re: Extend COPY FROM with HEADER <integer> to skip multiple lines |
Previous Message | Pavel Stehule | 2025-06-10 04:40:42 | Re: Sanding down some edge cases for PL/pgSQL reserved words |