macos exported symbols list not used for loadable modules

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: macos exported symbols list not used for loadable modules
Date: 2025-06-03 07:47:49
Message-ID: c70ca32e-b109-460d-9810-6e23ebb4473f@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On macOS, when building with the make system, the exported symbols list
(SHLIB_EXPORTS) is ignored. I don't think that is intentional. It was
probably just forgotten, since that combination has never actually been
used until now (for libpq-oauth).

(Alternatively: Am I missing something? Is this combination not useful?
Was it not supported in older versions at some point? I couldn't
think of anything.)

The meson build system handles this correctly.

I suggest that we fix this. I attach patch 0001 with a minimal fix,
patch 0002 is a bit more refactoring to make the code match the layout
for other platforms.

Attachment Content-Type Size
0001-Use-exported-symbols-list-on-macOS-for-loadable-modu.patch text/plain 842 bytes
0002-Refactor-export-symbols-list-handling-on-macOS-a-bit.patch text/plain 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2025-06-03 07:52:30 Re: Pathify RHS unique-ification for semijoin planning
Previous Message Michael Banck 2025-06-03 07:42:35 Re: Add log_autovacuum_{vacuum|analyze}_min_duration