| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add a check_hook for output_plugin_libraries |
| Date: | 2026-11-06 17:05:08 |
| Message-ID: | CAOYmi+k3jG4Wf=dq56ZYF8rCTxf0yPn7d3QV_x_J4ymZEu3COQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 30, 2026 at 2:39 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> Thanks for updating the patch.
Thanks for the review! This has been backpatched.
> Per my grep, it is rarely happen to put"?" at the end of elog() message.
We don't seem to have a unified style for can't-happen elog calls, but
I changed it to use "internal error:" to make it more clear that
someone should tell us if it happens.
Thanks,
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Manu | 2026-11-06 17:29:09 | Re: PG19 regression in ecd9288624a: JSON_ARRAY() indexes that go stale |
| Previous Message | Jacob Champion | 2026-11-06 17:02:46 | Re: [PATCH] Explain what the default output_plugin_libraries do |