RE: [PATCH] Add a check_hook for output_plugin_libraries

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Jacob Champion' <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PATCH] Add a check_hook for output_plugin_libraries
Date: 2026-09-30 09:39:24
Message-ID: OS7PR01MB183170040F50570C06A6D1060F58B2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Jacob,

Thanks for updating the patch. Mostly LGTM, one minor comment.

```
+ elog(ERROR, "invalid output_plugin_libraries syntax after check_hook?");
```

Per my grep, it is rarely happen to put"?" at the end of elog() message.
Maybe it's OK to say:

invalid list syntax in parameter \"%s\"

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-09-30 09:40:15 Re: Temporary slot leak when creation fails in a subtransaction
Previous Message Hannu Krosing 2026-09-30 09:29:03 Re: Direct TOAST v2, faster, smaller and no migration needed