Re: Proposal: Make cfbot fail on patches not created by "git format-patch"

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jelte Fennema-Nio <me(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date: 2025-05-16 16:24:10
Message-ID: CAOYmi+=ouL0ODvKJ21zN0+tGR5gEo7eHH7GjiTcs+Z8GDzsB2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> That outcome seems entirely horrible to me. If you want to flag the lack
> of a commit message somehow, fine, but don't prevent CI from running.

Personally I also prefer nudges to gates. Just like people already
deprioritize "Waiting on Author" entries a bit, having an obvious
"Patch Needs Work" note might gently help newcomers iterate on their
first submissions (or even communicate where a patch is in the
lifecycle! e.g. a Bugfix entry where the patch is marked incomplete
might motivate someone to jump in to fix it).

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Srinath Reddy Sadipiralla 2025-05-16 16:47:28 Re: Make wal_receiver_timeout configurable per subscription
Previous Message Tom Lane 2025-05-16 16:12:47 Re: Proposal: Make cfbot fail on patches not created by "git format-patch"