Re: Proposal: Make cfbot fail on patches not created by "git format-patch"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date: 2025-05-16 16:12:47
Message-ID: 37642.1747411967@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jelte Fennema-Nio <me(at)jeltef(dot)nl> writes:
> Based on the discussion there I'm planning to make the cfbot fail to apply
> a patch in the following two cases:
> ...
> To be clear, it means we don't
> run CI on patches created by piping "git diff" to a file anymore, as a way
> to nudge submitters into providing useful commit messages.

That outcome seems entirely horrible to me. If you want to flag the lack
of a commit message somehow, fine, but don't prevent CI from running.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-05-16 16:24:10 Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Previous Message Alena Rybakina 2025-05-16 16:12:38 Re: wrong query results on bf leafhopper