| From: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Make cfbot fail on patches not created by "git format-patch" |
| Date: | 2025-05-16 17:45:01 |
| Message-ID: | CAGECzQTgR-rurYDU3Y0D=0ZQPy47bNqmgEkGpLq8VmiQ+WG5UQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 16 May 2025 at 12:24, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > That outcome seems entirely horrible to me. If you want to flag the lack
> > of a commit message somehow, fine, but don't prevent CI from running.
>
> Personally I also prefer nudges to gates.
Okay, reasonable feedback. How about we add a CI job that does a
"quality check". That's much less strong, as all the other tests will
still run, but people would get a failing CI job which tells them that
something is wrong. We could also include a pgindent in that CI job.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-05-16 17:55:08 | Re: Proposal: Make cfbot fail on patches not created by "git format-patch" |
| Previous Message | Srinath Reddy Sadipiralla | 2025-05-16 16:47:28 | Re: Make wal_receiver_timeout configurable per subscription |