Re: [PATCH] Fix missing comma in Requires.private with a Make macro

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: fabriziomello(at)gmail(dot)com
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Wolfgang Walther <walther(at)technowledgy(dot)de>
Subject: Re: [PATCH] Fix missing comma in Requires.private with a Make macro
Date: 2025-05-07 19:50:12
Message-ID: CAOYmi+=e4p7O0Srub3oi9XicqhEor-9O_0LuKO5nfkN5eig_eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> LGTM

Thanks for the review!

>> Tested with GNU Make 3.81 (the compilation of which was slightly
>> painful; does anyone want to debate pulling that minimum version up
>> sometime soon?) and 4.3.
>
> Not sure if all animals have a minimum 4.3 make version. Do you?

Oh, I doubt that very much. I don't immediately see the Make version
in the configure logs for the animals, but lapwing for example is
running Debian Wheezy.

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-05-07 19:55:49 Re: Large expressions in indexes can't be stored (non-TOASTable)
Previous Message Masahiko Sawada 2025-05-07 19:35:33 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart