| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Large expressions in indexes can't be stored (non-TOASTable) |
| Date: | 2025-05-07 19:55:49 |
| Message-ID: | aBu6xdbOqelnZOCZ@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 07, 2025 at 08:00:39AM +0900, Michael Paquier wrote:
> On Tue, May 06, 2025 at 11:41:49AM -0500, Nathan Bossart wrote:
>> I brought this up with the RMT, and everyone seemed okay with committing it
>> for v18.
>
> Cool, thanks for the update.
>
>> I can move it back to replorigin_create(). I don't have a strong opinion
>> here.
>
> I think that I would the check there, as that's safer in the long-run
> to enforce the rule to all potential callers of this API. If the
> votes balance in favor of keeping it in the SQL function, that's OK by
> me as well, so feel free to ignore me if you feel strongly about it
> overall.
Committed with that change. That takes care of a good chunk of these TOAST
snapshot problems. I think there are about 4 others left, unless something
has changed since I last checked. I hope to look into those again soon.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-05-07 20:41:20 | Re: PG 18 release notes draft committed |
| Previous Message | Jacob Champion | 2025-05-07 19:50:12 | Re: [PATCH] Fix missing comma in Requires.private with a Make macro |