Re: [PATCH] Fix missing comma in Requires.private with a Make macro

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: fabriziomello(at)gmail(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Wolfgang Walther <walther(at)technowledgy(dot)de>
Subject: Re: [PATCH] Fix missing comma in Requires.private with a Make macro
Date: 2025-05-07 22:22:22
Message-ID: 83108.1746656542@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello
> <fabriziomello(at)gmail(dot)com> wrote:
>> Not sure if all animals have a minimum 4.3 make version. Do you?

> Oh, I doubt that very much. I don't immediately see the Make version
> in the configure logs for the animals, but lapwing for example is
> running Debian Wheezy.

Apple is still shipping

$ which make
/usr/bin/make

$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

I'm not sure why it claims to be an i386 build, because that's
the one thing it certainly isn't:

$ file /usr/bin/make
/usr/bin/make: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/usr/bin/make (for architecture x86_64): Mach-O 64-bit executable x86_64
/usr/bin/make (for architecture arm64e): Mach-O 64-bit executable arm64e

But at any rate, dropping compatibility with that would likely
be rather painful for some of us, even though most people building
PG on Mac probably use Homebrew or MacPorts and could get a newer
make version from there.

The next oldest make version we still have to contend with in the
wild might be RHEL8's 4.2.1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-05-07 22:23:52 Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
Previous Message Tom Lane 2025-05-07 21:54:31 Re: disabled SSL log_like tests