Re: Dead code in adminpack

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code in adminpack
Date: 2020-02-13 11:41:46
Message-ID: CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

Indeed, and actually I don't see when this codepath was reachable.

Patch LGTM.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Suraj Kharage 2020-02-13 11:44:23 Re: allow frontend use of the backend's core hashing functions
Previous Message Fujii Masao 2020-02-13 11:39:54 Re: table partitioning and access privileges