| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Dead code in adminpack |
| Date: | 2020-02-13 11:15:39 |
| Message-ID: | 32663.1581592539@antos |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've noticed that convert_and_check_filename() is always passed false for the
"logAllowed" argument - someone probably forgot to remove the argument when it
was decided that log files are no longer accepted. If the argument was removed,
the function would become a bit simpler, see the patch.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| Attachment | Content-Type | Size |
|---|---|---|
| adminpack_dead_code.patch | text/x-diff | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-02-13 11:36:52 | Re: [PATCH] Erase the distinctClause if the result is unique by definition |
| Previous Message | Alexey Bashtanov | 2020-02-13 11:13:32 | Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING |