| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dead code in adminpack |
| Date: | 2020-02-14 03:44:03 |
| Message-ID: | 20200214034403.GA1998@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote:
> On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
>> I've noticed that convert_and_check_filename() is always passed false for the
>> "logAllowed" argument - someone probably forgot to remove the argument when it
>> was decided that log files are no longer accepted. If the argument was removed,
>> the function would become a bit simpler, see the patch.
>
> Indeed, and actually I don't see when this codepath was reachable.
>
> Patch LGTM.
Thanks, applied.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-02-14 03:47:19 | Re: Wait event that should be reported while waiting for WAL archiving to finish |
| Previous Message | Masahiko Sawada | 2020-02-14 03:30:25 | Re: error context for vacuum to include block number |