Re: Bug in reindexdb's error reporting

On Fri, May 10, 2019 at 4:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On 2019-May-10, Julien Rouhaud wrote:
> >> I just noticed that reindexdb could report an extraneous message
> >> saying an error happened while reindexing a database if it failed
> >> reindexing a table or an index.
>
> > Kudos, good find -- that's a 14 years old bug, introduced in this commit:
>
> Yeah :-(.
>
> Patch is good as far as it goes, but I wonder if it'd be smarter to
> convert the function's "type" argument from a string to an enum,
> and then replace the if/else chains with switches?

I've also thought about it. I think the reason why type argument was
kept as a string is that reindex_one_database is doing:

appendPQExpBufferStr(&sql, type);

to avoid an extra switch to append the textual reindex type. I don't
have a strong opinion on whether to change that on master or not.