Re: Bug in reindexdb's error reporting

On 2019-May-10, Julien Rouhaud wrote:

> On Fri, May 10, 2019 at 4:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> > Patch is good as far as it goes, but I wonder if it'd be smarter to
> > convert the function's "type" argument from a string to an enum,
> > and then replace the if/else chains with switches?
>
> I've also thought about it. I think the reason why type argument was
> kept as a string is that reindex_one_database is doing:
>
> appendPQExpBufferStr(&sql, type);
>
> to avoid an extra switch to append the textual reindex type. I don't
> have a strong opinion on whether to change that on master or not.

I did have the same thought. It seem clear now that we should do it :-)
ISTM that the way to fix that problem is to use the proposed enum
everywhere and turn it into a string when generating the SQL command,
not before.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services