Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM

From: Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
To: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM
Date: 2020-03-27 15:58:38
Message-ID: CANtu0ojCsZHfSXGsJY6AF_pHwrD01tUa_mQnsnBcnY5ztkYq3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

> Probably, patch in this thread should fix this in btree_xlog_split() too?

I have spent some time trying to find any possible race condition
between btree_xlog_split and _bt_walk_left… But I can’t find any.
Also, I have tried to cause any issue by putting pg_sleep put into
btree_xlog_split (between releasing and taking of locks) but without
any luck.

I agree it is better to keep the same locking logic for primary and
standby in general. But it is a possible scope of another patch.

Thanks,
Michail.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2020-03-27 16:23:26 Re: pgbench - refactor init functions with buffers
Previous Message David Steele 2020-03-27 15:36:34 Re: psql FETCH_COUNT feature does not work with combined queries