| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - refactor init functions with buffers |
| Date: | 2020-03-27 16:23:26 |
| Message-ID: | ede1338c-7640-c5bb-5a58-d9e208fd8740@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/6/19 12:48 AM, Fabien COELHO wrote:
>
> Hello Andres,
>
>>> Attached v3 shorten some lines and adds "append_tablespace".
>
> A v4 which just extends the patch to newly added 'G'.
>
>> I'd prefer not to expand the use of pqexpbuffer in more places, and
>> instead rather see this use StringInfo, now that's also available to
>> frontend programs.
>
> Franckly, one or the other does not matter much to me.
FWIW, I agree with Andres with regard to using StringInfo.
Also, the changes to executeStatementExpect() and adding
executeStatement() do not seem to fit in with the purpose of this patch.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2020-03-27 16:33:34 | Re: INSERT ... OVERRIDING USER VALUE vs GENERATED ALWAYS identity columns |
| Previous Message | Michail Nikolaev | 2020-03-27 15:58:38 | Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM |