From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: psql FETCH_COUNT feature does not work with combined queries |
Date: | 2020-03-27 15:36:34 |
Message-ID: | a2b1f39d-9980-bcca-1969-c9a8b76735f7@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Fabien,
On 1/6/20 5:20 PM, Tomas Vondra wrote:
> On Fri, Jul 26, 2019 at 04:13:23PM +0000, Fabien COELHO wrote:
>>
>>> FETCH_COUNT does not work with combined queries, and probably has
>>> never worked since 2006.
>>
>> For the record, this bug has already been reported & discussed by
>> Daniel Vérité a few months back, see:
>>
>> https://www.postgresql.org/message-id/flat/a0a854b6-563c-4a11-bf1c-d6c6f924004d%40manitou-mail.org
>>
>>
>> Given the points of view expressed on this thread, especially Tom's
>> view against improving the lexer used by psql to known where query
>> ends, it looks that my documentation patch is the way to go in the
>> short term, and that if the "always show query results" patch is
>> committed, it might simplify a bit solving this issue as the PQexec
>> call is turned into PQsendQuery.
>>
>
> Assuming there's no one willing to fix the behavior (and that seems
> unlikely given we're in the middle of a 2020-01 commitfest) it makes
> sense to at least document the behavior.
>
> That being said, I think the proposed patch may be a tad too brief. I
> don't think we need to describe the exact behavior, of course, but maybe
> it'd be good to mention that the behavior depends on the type of the
> last command etc. Also, I don't think "combined query" is a term used
> anywhere in the code/docs - I think the proper term is "multi-query
> string".
Any thoughts on Tomas' comments?
I'll mark this Waiting on Author because I feel like some response
and/or a new patch is needed.
Regards,
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Michail Nikolaev | 2020-03-27 15:58:38 | Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM |
Previous Message | Alvaro Herrera | 2020-03-27 15:34:02 | Re: shared-memory based stats collector |