| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Fix typo 586/686 in atomics/arch-x86.h |
| Date: | 2025-12-19 07:23:31 |
| Message-ID: | CANWCAZZhAcjY+b-KCHX74YuDGL1ffS=vHr68UHH9CBXEn+weUg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 28, 2025 at 4:00 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 28 Nov 2025, at 09:44, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> wrote:
> >
> > That's a typo in src/include/port/atomics/arch-x86.h, isn't it ?:
> > if defined(__i568__) || defined(__i668__) || /* gcc i586+ */
> > If yes, then a patch is attached. Not that it harms something or
> > somebody has such old hardware, but I've just spotted it while looking
> > for something else.
>
> That indeed looks like a clear typo, but if noone has complained since 2017
> then maybe removing the checks is the right course of action?
I believe CI tests with -m32, so as long as we do that we should
probably make that work the way we think it does.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-12-19 07:33:33 | Re: Sequence Access Methods, round two |
| Previous Message | Ashutosh Bapat | 2025-12-19 07:02:49 | Re: Report bytes and transactions actually sent downtream |