| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Sequence Access Methods, round two |
| Date: | 2025-12-19 07:33:33 |
| Message-ID: | aUT_zfgDSMKj-LEo@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 19, 2025 at 02:45:47PM +0800, Xuneng Zhou wrote:
> Thanks for working on this. I tried to review patch set v25, but I
> wasn’t able to apply it cleanly on HEAD.
Strange. It rebases correctly even on today's HEAD at 5cdbec5aa9dc.
> We have two macros the same here.
>
> 2. Duplicate stmt->tableElts = NIL; in sequence.c:
It looks like I have fat-fingered some rebases here.
> Should we update this to "seq_local_redo: unknown op code %u”?
Yep, thanks.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v26-0001-Integrate-addition-of-attributes-for-sequences-w.patch | text/x-diff | 11.2 KB |
| v26-0002-Refactor-code-for-in-core-local-sequences.patch | text/x-diff | 57.0 KB |
| v26-0003-Sequence-access-methods-backend-support.patch | text/x-diff | 64.9 KB |
| v26-0004-Sequence-access-methods-dump-restore-support.patch | text/x-diff | 21.8 KB |
| v26-0005-Sequence-access-methods-core-documentation.patch | text/x-diff | 9.5 KB |
| v26-0006-Refactor-logic-for-page-manipulations-of-sequenc.patch | text/x-diff | 7.8 KB |
| v26-0007-snowflake-Add-sequence-AM-based-on-it.patch | text/x-diff | 25.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-12-19 07:50:15 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | John Naylor | 2025-12-19 07:23:31 | Re: Fix typo 586/686 in atomics/arch-x86.h |