| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Fix typo 586/686 in atomics/arch-x86.h |
| Date: | 2025-11-28 09:00:21 |
| Message-ID: | 4FD9BE34-FDD1-4D4D-839F-B9D2596D6084@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 28 Nov 2025, at 09:44, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> wrote:
>
> That's a typo in src/include/port/atomics/arch-x86.h, isn't it ?:
> if defined(__i568__) || defined(__i668__) || /* gcc i586+ */
> If yes, then a patch is attached. Not that it harms something or
> somebody has such old hardware, but I've just spotted it while looking
> for something else.
That indeed looks like a clear typo, but if noone has complained since 2017
then maybe removing the checks is the right course of action?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-11-28 09:01:59 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Jakub Wartak | 2025-11-28 08:44:37 | Fix typo 586/686 in atomics/arch-x86.h |