Re: BUG #19095: Test if function exit() is used fail when linked static

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, BharatDB <bharatdbpg(at)gmail(dot)com>, torsten(dot)rupp(at)gmx(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org, VASUKI M <vasukim1992002(at)gmail(dot)com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: 2025-11-19 13:17:07
Message-ID: CAN55FZ2Wqv+maXTfNO6+y=5400w7hCMo6RQhasqp=nrsODSBpg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi,

On Fri, 14 Nov 2025 at 15:11, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 12 Nov 2025, at 09:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Wed, Nov 12, 2025 at 09:13:09AM +0100, Daniel Gustafsson wrote:
> >> On 12 Nov 2025, at 07:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >>> Personally I'm okay with whitelisting pthread_exit() as
> >>> Torsten suggested.
> >>
> >> +1, we already have a few whitelisted entries and pthread_exit seems perfectly
> >> reasonable to add to that list.
> >
> > WFM.
>
> The attached trivial diff adds this to the whitelist clause in the Makefile. I
> experimented with adding this to Meson, and while it's trivial enough to do the
> run_command with libpq_so.full_path, it's less clear to me exactly where in the
> build it should be added. I've pinged my colleague Bilal who is much better at
> Meson than me to collaborate on that as a separate fix.

Sorry for the late reply. I replaced the Makefile portion with the
Perl script, so that it can be used for both meson and autoconf build
systems. The script takes two arguments

- input_file -> path of library file.
- stamp_file -> to create a stamp file for the meson build, so that
meson does not run while the library file is not changed. Autoconf
build does not use this option.

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v1-0001-Add-exit-check-for-libpq.so-for-meson-build.patch text/x-patch 4.1 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Heikki Linnakangas 2025-11-19 16:08:22 Re: pg_resetwal prints new OldestXID in wrong circumstances
Previous Message BharatDB 2025-11-19 12:29:09 Re: BUG #19095: Test if function exit() is used fail when linked static

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2025-11-19 13:39:18 Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting
Previous Message Daniel Gustafsson 2025-11-19 13:04:44 Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions