Re: pg_resetwal prints new OldestXID in wrong circumstances

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_resetwal prints new OldestXID in wrong circumstances
Date: 2025-11-19 16:08:22
Message-ID: 638e63ba-b8a3-4236-9c48-0d4a5ef2f034@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 19/11/2025 12:05, Bertrand Drouvot wrote:
> On Wed, Nov 19, 2025 at 11:52:31AM +0200, Heikki Linnakangas wrote:
>> Printing the new OldestXID value is incorrectly tied to whether the
>> --next-transaction-id option is given, so this prints it, even though
>> OldestXID is not being modified:
>
> Nice catch!
>
>> This seems to have been an oversight when the --oldest-transaction-id option
>> was added (commit 74cf7d46a91d).
>
> yeah.
>
>> Before that, OldestXID was reset when the
>> --next-transaction-id option was given.
>>
>> Fix attached. Barring objections, I will commit and backpatch this.
>
> LGTM, thanks!

Committed, thanks!

- Heikki

In response to

Browse pgsql-bugs by date

  From Date Subject
Previous Message Nazir Bilal Yavuz 2025-11-19 13:17:07 Re: BUG #19095: Test if function exit() is used fail when linked static