| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Sugamoto Shinya <shinya34892(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Date: | 2025-11-19 13:04:44 |
| Message-ID: | E06CED92-C740-4264-99E2-EE4DB2453BCF@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 19 Nov 2025, at 14:01, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> You changed the HINT message to use format arguments,
> but I still think it's better to embed the values directly (e.g.,
> Valid encodings are "base64", "base64url", "escape", and "hex".)
> for consistency with similar HINT messages. If this message is
> used in many places a parameterized style would help translators,
> but that benefit doesn't apply here.
>
> Attached is an updated version of the patch. I switched
> the HINT message to the embedded form and updated the commit message.
> Barring any objections, I'm thinking to commit this.
My intepreration was that this version was already objected to by Peter
upthread in c5c937dc-de8e-4284-be25-5d5eaf089d00(at)eisentraut(dot)org(dot) The point
there being that punctuation in lists is subject to translation.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-11-19 13:17:07 | Re: BUG #19095: Test if function exit() is used fail when linked static |
| Previous Message | Fujii Masao | 2025-11-19 13:01:03 | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |