| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Stabilize and shorten test_checksums/013_rewind test |
| Date: | 2026-09-28 12:49:28 |
| Message-ID: | CAN55FZ1h+wTOpGRV2Tdo-mHPCPWDO_Lj-T304mmMs3ZACW8t_w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 28 Sept 2026 at 12:46, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> I've been looking at this patch and have tested it extensively both on local
> hardware and CI instances. Copilot review pointed out one thing which I think
> is accurate (though unlikely to happen), if the START WAL LOCATION and
> CHECKPOINT LOCATION straddle segments then the test would fail. Extracting the
> WAL filename from $shutdown_ckpt is the safer option. That fix and some commit
> message tweaking are the only changes in the attached v4.
Thanks, v4 LGTM.
There is one more issue found by an LLM: the checkpoint record itself
can straddle two WAL segments. However, I think this is a very rare
corner case and might not be worth fixing.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-09-28 13:15:08 | Re: Stabilize and shorten test_checksums/013_rewind test |
| Previous Message | Nisha Moond | 2026-09-28 12:37:34 | Fix apply worker crash when subscriber table has only a deferrable primary key |