| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Stabilize and shorten test_checksums/013_rewind test |
| Date: | 2026-09-28 13:15:08 |
| Message-ID: | F888A261-0717-46CD-94FE-B6B0FC933A0B@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 28 Sep 2026, at 14:49, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Mon, 28 Sept 2026 at 12:46, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>> I've been looking at this patch and have tested it extensively both on local
>> hardware and CI instances. Copilot review pointed out one thing which I think
>> is accurate (though unlikely to happen), if the START WAL LOCATION and
>> CHECKPOINT LOCATION straddle segments then the test would fail. Extracting the
>> WAL filename from $shutdown_ckpt is the safer option. That fix and some commit
>> message tweaking are the only changes in the attached v4.
>
> Thanks, v4 LGTM.
>
> There is one more issue found by an LLM: the checkpoint record itself
> can straddle two WAL segments. However, I think this is a very rare
> corner case and might not be worth fixing.
Thanks. I'll add a comment explaining this in the test to make sure we keep it
in mind should we need it.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-09-28 13:23:39 | Re: Allow table AMs to define their own reloptions |
| Previous Message | Nazir Bilal Yavuz | 2026-09-28 12:49:28 | Re: Stabilize and shorten test_checksums/013_rewind test |