| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Stabilize and shorten test_checksums/013_rewind test |
| Date: | 2026-09-28 09:46:45 |
| Message-ID: | A0DEFB5D-718B-4486-9D15-E9BC2AB35EF9@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 23 Sep 2026, at 12:15, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> On Tue, 22 Sept 2026 at 00:38, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>> Shouldn't 021 get the same fix (0001)? That's only executed with
>> checksum_extended so its not that visible on CI, but it has the same
>> issue.
>
> Yes, you are right. I realized that we can do the same thing for all
> test_checksum tests, so I applied similar change to all of the related
> checksum tests in 0001.
I've been looking at this patch and have tested it extensively both on local
hardware and CI instances. Copilot review pointed out one thing which I think
is accurate (though unlikely to happen), if the START WAL LOCATION and
CHECKPOINT LOCATION straddle segments then the test would fail. Extracting the
WAL filename from $shutdown_ckpt is the safer option. That fix and some commit
message tweaking are the only changes in the attached v4.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Avoid-idle-WAL-waits-in-checksum-tests.patch | application/octet-stream | 9.6 KB |
| v4-0002-Fix-WAL-file-selection-in-013_rewind-test.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vlad Lesin | 2026-09-28 09:54:43 | ReplicationSlotRelease() clobbers another backend's statusFlags entry |
| Previous Message | Peter Smith | 2026-09-28 09:18:17 | Re: [PATCH] Table sync race with REFRESH PUBLICATION |