Re: Unused stricture field in xlogreader:DecodedBkpBlock

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Mikhail Gribkov <youzhick(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unused stricture field in xlogreader:DecodedBkpBlock
Date: 2025-10-17 12:06:06
Message-ID: CAN55FZ1+XtvaSLqSxRHUz=uw2StHwtM7mC6qdaYGewwzAAqcuA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov <youzhick(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever used in the current code and not even mentioned in any comments. It just occupies memory and removing it doesn't seem to break anything.
> Should we remove it maybe? Attached is the removal patch.

Thanks for the patch! It looks like it should have been removed in the
3f1ce97346.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-10-17 12:07:18 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Previous Message Mikhail Gribkov 2025-10-17 11:37:07 Unused stricture field in xlogreader:DecodedBkpBlock