| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Mikhail Gribkov <youzhick(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unused stricture field in xlogreader:DecodedBkpBlock |
| Date: | 2025-10-17 18:22:51 |
| Message-ID: | CAD21AoC-uh3ndFpovNW8HGzTWvBBFDt8CzFYvjsJcebVkCgcUw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 17, 2025 at 5:06 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov <youzhick(at)gmail(dot)com> wrote:
> >
> > Hi hackers,
> >
> > I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever used in the current code and not even mentioned in any comments. It just occupies memory and removing it doesn't seem to break anything.
> > Should we remove it maybe? Attached is the removal patch.
>
> Thanks for the patch! It looks like it should have been removed in the
> 3f1ce97346.
>
+1 to remove it. I'll push the patch, barring objections.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-10-17 18:31:19 | Re: Unused stricture field in xlogreader:DecodedBkpBlock |
| Previous Message | Nathan Bossart | 2025-10-17 18:06:16 | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |