| From: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Unused stricture field in xlogreader:DecodedBkpBlock |
| Date: | 2025-10-17 11:37:07 |
| Message-ID: | CAMEv5_sxuaiAfSy1ZyN=7UGbHg3C10cwHhEk8nXEjiCsBVs4vQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever
used in the current code and not even mentioned in any comments. It just
occupies memory and removing it doesn't seem to break anything.
Should we remove it maybe? Attached is the removal patch.
--
best regards,
Mikhail A. Gribkov
e-mail: youzhick(at)gmail(dot)com
*http://www.flickr.com/photos/youzhick/albums
<http://www.flickr.com/photos/youzhick/albums>*
http://www.strava.com/athletes/5085772
phone: +7(916)604-71-12
Telegram: @youzhick
| Attachment | Content-Type | Size |
|---|---|---|
| v1-Remove-unused-data_bufsz.patch | application/octet-stream | 329 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-10-17 12:06:06 | Re: Unused stricture field in xlogreader:DecodedBkpBlock |
| Previous Message | Shubham Khanna | 2025-10-17 11:20:19 | Re: Add support for specifying tables in pg_createsubscriber. |