Re: tablecmds: reject CLUSTER ON for partitioned tables earlier

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date: 2026-01-27 08:41:09
Message-ID: CAN4CZFOPSa714weVjrwSTJXHNPNrO=1v8Mf3tH5351d==9K6wg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> can the previous error path in
> mark_index_clustered() be reached through a different mean than ALTER
> TABLE?

That was one of the things we discussed in the previous emails. The
remaining callers of that function are VACUUM FULL and CLUSTER. It
definitely can't be hit by VACUUM (it passes an InvalidOid for an
index), but CLUSTER is a bit more difficult to follow. It seems like
to me that it shouldn't be hit (CLUSTER only calls it for leaf
partitions, where the check will be false), but I'm not 100% sure
about my diagnosis.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-01-27 08:46:10 Re: Newly created replication slot may be invalidated by checkpoint
Previous Message Jim Jones 2026-01-27 08:36:54 Re: display hot standby state in psql prompt