| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: tablecmds: reject CLUSTER ON for partitioned tables earlier |
| Date: | 2026-01-27 07:48:27 |
| Message-ID: | aXhty3YQceFniabz@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 27, 2026 at 07:13:04AM +0800, Chao Li wrote:
> I added two new test cases in 0002 that trigger the check.
>
> BTW, this is the CF entry:
> https://commitfest.postgresql.org/patch/6415/. You may mark yourself
> as a reviewer, and once you consider the patch is ready to go, would
> you mind change the status to Ready For Committer?
There is more to this set of changes than it looks at first sight.
Hence, one question about 0001: can the previous error path in
mark_index_clustered() be reached through a different mean than ALTER
TABLE? If yes, we should have a test for it. If no, it could be
switched to an elog(ERROR) or an assertion. The code paths leading to
the previous error should be analyzed further.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajay Pal | 2026-01-27 07:49:38 | Re: pg_plan_advice |
| Previous Message | Michael Paquier | 2026-01-27 07:39:36 | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |