| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "suyu(dot)cmj" <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, tomas <tomas(at)vondra(dot)me>, michael <michael(at)paquier(dot)xyz>, "bharath(dot)rupireddyforpostgres" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Newly created replication slot may be invalidated by checkpoint |
| Date: | 2026-01-27 08:46:10 |
| Message-ID: | CAA4eK1KHObZ-giSMwrTchtvjXs8yj0sQw9Jt-x2M9Nqxapkjvg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 26, 2026 at 3:06 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> > On Jan 26, 2026, at 13:35, Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > Dear Hou,
> >
> > Thanks for updating the patch. I ran tests and reproducer [1] for all versions.
> > Confirmed the issue happened before the patch and fixed after applying them.
> >
> > One difference between master and others is that pg_sync_replication_slots()
> > on HEAD is not returned. Because the behavior was changed by 0d2d4a0, not
> > related with the fix.
> >
> > I feel these patches are enough good shape.
> >
> > [1]: https://www.postgresql.org/message-id/TY7PR01MB14554DBE84290130EB421DD28F596A%40TY7PR01MB14554.jpnprd01.prod.outlook.com
> >
> > Best regards,
> > Hayato Kuroda
> > FUJITSU LIMITED
> >
>
> Yeah, I agree v4 is solid. I have a few nitpicks:
>
Pushed after minor cosmetic changes.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-01-27 08:48:02 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Zsolt Parragi | 2026-01-27 08:41:09 | Re: tablecmds: reject CLUSTER ON for partitioned tables earlier |