| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Subject: | Re: Eager aggregation, take 3 |
| Date: | 2025-10-09 01:51:03 |
| Message-ID: | CAMbWs48TAaXA=8B47yi6gJcufNeig05cMrXer4tyqEGKu83qpA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 8, 2025 at 11:45 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Oct 7, 2025 at 6:57 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > I retained the name of this field though.
> For what it's worth, I also don't like that field name. I'm not sure
> what to propose instead, but I don't think apply_at is very clear.
This field represents the set of relids at which partial aggregation
is applied. So how about naming it partial_agg_designated_relids?
That feels a bit verbose, though. How about partial_agg_relids or,
for brevity, agg_relids instead?
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-09 01:57:41 | Re: [PATCH] Add tests for Bitmapset |
| Previous Message | Richard Guo | 2025-10-09 01:49:48 | Re: Eager aggregation, take 3 |