| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Subject: | Re: Eager aggregation, take 3 |
| Date: | 2025-10-09 02:13:28 |
| Message-ID: | 2799576.1759976008@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> On Wed, Oct 8, 2025 at 11:45 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> For what it's worth, I also don't like that field name. I'm not sure
>> what to propose instead, but I don't think apply_at is very clear.
> This field represents the set of relids at which partial aggregation
> is applied. So how about naming it partial_agg_designated_relids?
> That feels a bit verbose, though. How about partial_agg_relids or,
> for brevity, agg_relids instead?
I might be missing a subtlety here, but how about
"apply_aggregation_at" or "apply_partial_agg_at"?
I don't think including "relids" in the field name adds anything,
given the field's declared type and comments.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-10-09 02:24:49 | Re: plan shape work |
| Previous Message | Michael Paquier | 2025-10-09 02:12:50 | Re: [PATCH] Add tests for Bitmapset |