| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-09 01:57:41 |
| Message-ID: | CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a+XLQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 9 Oct 2025 at 07:48, Greg Burd <greg(at)burd(dot)me> wrote:
> bms = bms_del_member(bms, member);
> + num_members--;
> + memmove(members + pos, members + pos + 1,
> + (num_members - pos) * sizeof(int));
I don't think there's any need to maintain the order of that members
array, so couldn't you just do this?:
bms = bms_del_member(bms, member);
members[pos] = members[--num_members];
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-10-09 02:05:36 | RE: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE |
| Previous Message | Richard Guo | 2025-10-09 01:51:03 | Re: Eager aggregation, take 3 |