| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tatsuro Yamada <tatsuro(dot)yamada(at)ntt(dot)com> |
| Cc: | Tatsuro Yamada <yamatattsu(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add enable_groupagg GUC parameter to control GroupAggregate usage |
| Date: | 2026-07-09 01:01:35 |
| Message-ID: | CAMbWs48=Kv9i-0fyC7dg5YEz-e0ieDq6OBy=Z-3z4A2gncP_fA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 8, 2026 at 8:54 PM Tatsuro Yamada <tatsuro(dot)yamada(at)ntt(dot)com> wrote:
> I'm in favor of committing this.
> Before you do, I'd like to clarify one point regarding the commit message.
> Would it make sense to list both of us as authors?
>
> The reason I ask is that you made substantial changes to the patch,
> including handling additional plan nodes such as SetOp and adding regression
> tests. Given those contributions, I wondered whether it would be more
> appropriate for both of us to be listed as authors. (I've seen past commits that
> included two Author: lines.)
> I'm happy to leave that decision to you.
Pushed.
I still listed myself as Co-authored-by rather than Author, because I
want to give full credit to you, as this is your idea and your patch.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-07-09 01:36:34 | Re: Include sequences in publications created by pg_createsubscriber |
| Previous Message | Tom Lane | 2026-07-09 00:14:49 | Re: s/pg_attribute_always_inline/pg_always_inline/? |