| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Include sequences in publications created by pg_createsubscriber |
| Date: | 2026-07-09 01:36:34 |
| Message-ID: | CAHut+PsjAiTWT_tdUKHh0XBR=u1PwRxdYsRy2WLXQM6Ko3wgXg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some review comments for v8
======
doc/src/sgml/ref/pg_createsubscriber.sgml
1.
+ which ensures each table is brought up to a synchronized state. When using
+ internally generated publications, the publications automatically include
+ all sequences in the database; however, sequence values are not
+ automatically synchronized.
Maybe "automatically" 2x in the same sentence is a bit much. The rest
can also be simpler.
SUGGESTION
Internally generated publications include all sequences in the
database, but their values are not automatically synchronized.
~~~
2.
+ objects defined by that publication. Otherwise,
+ <application>pg_createsubscriber</application> creates a publication
+ using <link linkend="sql-createpublication-params-for-all-tables">
+ <literal>FOR ALL TABLES</literal></link> and <link
+ linkend="sql-createpublication-params-for-all-sequences"> <literal>ALL
+ SEQUENCES</literal></link>. These generated publications has the
+ following name pattern:
2a.
The space before the last <literal> tag here is probably not deliberate.
~
2b.
typo: /has the/have the/
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-07-09 02:15:20 | Re: [PATCH] no table rewrite when set column type to constrained domain |
| Previous Message | Richard Guo | 2026-07-09 01:01:35 | Re: Add enable_groupagg GUC parameter to control GroupAggregate usage |