| From: | Hannu Krosing <hannuk(at)google(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Ajit Awekar <ajitpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dave Cramer <davecramer(at)gmail(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Periodic authorization expiration checks using GoAway message |
| Date: | 2025-11-28 17:52:20 |
| Message-ID: | CAMT0RQQTahXBBDRsB9z9wzvB7y9iYO7XiVfTX+2-7DKebxcbrw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Also have not looked at the patch, but we should also make sure that
there is not just be GoAway, but also a way to re-authenticate or
"extend lease" or whatever the terminology is for a specific
authentication method.
So maybe the message should be ReAuthentiocateOrElse" ?
On Fri, Nov 28, 2025 at 6:19 PM Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> On Fri, Nov 28, 2025, 04:39 Ajit Awekar <ajitpostgres(at)gmail(dot)com> wrote:
>>
>> This patch depends on the "GoAway" protocol message proposal currently under review here: https://www.postgresql.org/message-id/DDPQ1RV5FE9U.I2WW34NGRD8Z%40jeltef.nl Please apply this patch on top of the GoAway patch.
>
>
> A review of the GoAway patch from you would definitely be appreciated (even if there's no actionable feedback like: "this looks good and I managed use it for my own patch successfully")
>
>> The Solution: To handle this authorization gap gracefully, this patch leverages the pending GoAway protocol message to notify clients.
>
>
> I didn't look at the patch (I'm on my phone). But my first thought is that only relying on the proposed version of GoAway is insufficient for anything related to security. The GoAway message is both best effort, and only supported with newer protocol versions. So while I think it's a good usecase for GoAway, I think there *also* needs to be a hard timeout at which point the connection gets forcefully terminated if it's using old credentials.
>
> Regarding the configurable interval that you describe for checking auth changes, I think it might be better to register a SysCache update receiver instead (or just poll the SysCache value
>
> Finally, can you register this patch on the commitfest? https://commitfest.postgresql.org/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2025-11-28 17:58:46 | Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements |
| Previous Message | Álvaro Herrera | 2025-11-28 17:30:40 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |