| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Ajit Awekar <ajitpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dave Cramer <davecramer(at)gmail(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Periodic authorization expiration checks using GoAway message |
| Date: | 2025-11-28 17:18:57 |
| Message-ID: | CAGECzQS7Eab2vFBgE8DAq1RnTVoYb0a5X7iMyaNvApAHA7Qm2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 28, 2025, 04:39 Ajit Awekar <ajitpostgres(at)gmail(dot)com> wrote:
> This patch depends on the "GoAway" protocol message proposal currently
> under review here:
> https://www.postgresql.org/message-id/DDPQ1RV5FE9U.I2WW34NGRD8Z%40jeltef.nl
> Please apply this patch on top of the GoAway patch.
>
A review of the GoAway patch from you would definitely be appreciated (even
if there's no actionable feedback like: "this looks good and I managed use
it for my own patch successfully")
The Solution: To handle this authorization gap gracefully, this patch
> leverages the pending GoAway protocol message to notify clients.
>
I didn't look at the patch (I'm on my phone). But my first thought is that
only relying on the proposed version of GoAway is insufficient for anything
related to security. The GoAway message is both best effort, and only
supported with newer protocol versions. So while I think it's a good
usecase for GoAway, I think there *also* needs to be a hard timeout at
which point the connection gets forcefully terminated if it's using old
credentials.
Regarding the configurable interval that you describe for checking auth
changes, I think it might be better to register a SysCache update receiver
instead (or just poll the SysCache value
Finally, can you register this patch on the commitfest?
https://commitfest.postgresql.org/
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-11-28 17:30:40 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |
| Previous Message | Andres Freund | 2025-11-28 17:14:08 | Re: Remove unused function parameters, part 2: replication |