Re: Free indexed_tlist memory explicitly within set_plan_refs()

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date: 2015-07-24 17:57:43
Message-ID: CAM3SWZTKHVArKZ_4Y9_ReL9mh-jBJoMULX9LCH+bfme7rkyTEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 24, 2015 at 2:58 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I've pushed a version of your patch. I just opted to remove p_is_update
> instead of allowing both to be set at the same time. To me that seemed
> simpler.

I would be hesitant to remove a struct field from a struct that
appears as a hook argument. Someone's extension (that uses parser
hooks) might have been relying on that. Perhaps not a big deal.

Thanks
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-07-24 17:57:51 Re: Improving replay of XLOG_BTREE_VACUUM records
Previous Message Heikki Linnakangas 2015-07-24 17:27:42 Re: Supporting TAP tests with MSVC and Windows