From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Free indexed_tlist memory explicitly within set_plan_refs() |
Date: | 2015-07-24 17:58:25 |
Message-ID: | 4D31E804-8CA9-4F51-8DD2-22E6A69A4347@anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On July 24, 2015 7:57:43 PM GMT+02:00, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>On Fri, Jul 24, 2015 at 2:58 AM, Andres Freund <andres(at)anarazel(dot)de>
>wrote:
>> I've pushed a version of your patch. I just opted to remove
>p_is_update
>> instead of allowing both to be set at the same time. To me that
>seemed
>> simpler.
>
>I would be hesitant to remove a struct field from a struct that
>appears as a hook argument. Someone's extension (that uses parser
>hooks) might have been relying on that. Perhaps not a big deal.
They'd also be affected by the change in meaning...
---
Please excuse brevity and formatting - I am writing this on my mobile phone.
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-07-24 17:58:42 | Re: fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it? |
Previous Message | Jim Nasby | 2015-07-24 17:57:51 | Re: Improving replay of XLOG_BTREE_VACUUM records |