Re: Compilation issue on Solaris.

From: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Compilation issue on Solaris.
Date: 2022-09-06 06:18:35
Message-ID: CALtqXTfJs6=-iT8psFRR7vDm5hD12yY55S-6aBe7RKuM-GhqXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 6, 2022 at 9:24 AM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
wrote:

> On Sun, Jul 10, 2022 at 9:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > > Something bothers me about adding yet more clutter to every compile
> > > line for the rest of time to solve a problem that exists only for
> > > unpatched systems, and also that it's not even really a Solaris thing,
> > > it's a C11 thing.
> >
> > I tend to agree with this standpoint: if it's only a warning, and
> > it only appears in a small range of not-up-to-date Solaris builds,
> > then a reasonable approach is "update your system if you don't want
> > to see the warning".
> >
> > A positive argument for doing nothing is that there's room to worry
> > whether -D__STDC_WANT_LIB_EXT1__ might have any side-effects we
> > *don't* want.
>
> This is still listed in the CF as needing review, so I went and marked
> it rejected.
>
> +1, Thanks

> --
> John Naylor
> EDB: http://www.enterprisedb.com
>

--
Ibrar Ahmed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2022-09-06 06:25:05 Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
Previous Message Pavel Stehule 2022-09-06 06:09:42 Re: Modernizing our GUC infrastructure