| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
| Date: | 2021-12-31 06:39:02 |
| Message-ID: | CALj2ACXx9rCRP7RiLKDgh76oUqdsifjeNRGqmgxDmh8K8X85SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 30, 2021 at 6:24 AM Cary Huang <cary(dot)huang(at)highgo(dot)ca> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: not tested
>
> Hi
>
> The patch applies and tests fine. I don't think there is any harm having little extra statistical information about the checkpoint process. In fact, it could be useful in identifying a bottleneck during the checkpoint process as the stats exactly the time taken to do the file IO in pg_logical dir.
Thanks for the review. Here's the CF entry
https://commitfest.postgresql.org/36/3389/, please feel free to add
you as reviewer.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Zakhlystov | 2021-12-31 09:26:57 | libpq compression (part 2) |
| Previous Message | Bharath Rupireddy | 2021-12-31 06:14:46 | Re: skip replication slot snapshot/map file removal during end-of-recovery checkpoint |