| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
| Date: | 2022-03-11 20:05:11 |
| Message-ID: | 20220311200511.GA682814@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
+ CheckpointStats.repl_map_cutoff_lsn = cutoff;
Could we set repl_map_cutoff_lsn closer to where it is calculated? Right
now, it's set at the bottom of the function just before the directory is
freed. Is there a strong reason to do it there?
+ "logical rewrite mapping file(s) removed/synced=" UINT64_FORMAT ", size=%zu bytes, time=%ld.%03d s, cutoff LSN=%X/%X",
Can we split out the "removed" versus "synced" files? Otherwise, I think
this is basically just telling us how many files are in the mappings
directory.
+ CheckpointStats.repl_snap_cutoff_lsn = cutoff;
I have the same note for this one as I have for repl_map_cutoff_lsn.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-11 20:16:35 | Re: Proposal for internal Numeric to Uint64 conversion function. |
| Previous Message | Nathan Bossart | 2022-03-11 19:31:58 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |