| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fdw batch insert error out when set batch_size > 65535 |
| Date: | 2021-06-09 04:20:57 |
| Message-ID: | CALj2ACXoxbNhpKx2r29OyBdx+fA51Xsv80B-9-xyp1CeBL3ckQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 9, 2021 at 12:04 AM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> No, the "Int16" refers to the FE/BE documentation, where we use Int16.
> But in the C code we interpret it as uint16.
Hm. I see that in protocol.sgml Int16 is being used.
> I've added a simple regression test to postgres_fdw, testing that batch
> sizes > 65535 work fine, and pushed the fix.
I was earlier thinking of adding one, but stopped because it might
increase the regression test execution time. It looks like that's true
- with and without the test case it takes 17 sec and 4 sec
respectively on my dev system which is 4X slower. I'm not sure if this
is okay.
With Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-06-09 04:26:49 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Michael Paquier | 2021-06-09 03:46:27 | Re: Error on pgbench logs |